Merged
Conversation
Member
ndelangen
commented
Mar 12, 2025
ndelangen
commented
- Upgraded Storybook dependencies to version 9.0.0-0 in package.json and package-lock.json.
- Changed the module resolution strategy in tsconfig.json to "bundler" and updated the module type to "Preserve".
- Updated TypeScript target to ES2022.
- Adjusted imports in story files to use "@storybook/react-vite" and added a mock function for button click events.
- Cleaned up unused code and comments in various files.
- Upgraded Storybook dependencies to version 9.0.0-0 in package.json and package-lock.json. - Changed the module resolution strategy in tsconfig.json to "bundler" and updated the module type to "Preserve". - Updated TypeScript target to ES2022. - Adjusted imports in story files to use "@storybook/react-vite" and added a mock function for button click events. - Cleaned up unused code and comments in various files.
winkerVSbecks
approved these changes
Mar 12, 2025
valentinpalkovic
approved these changes
Mar 12, 2025
- Removed outdated dependencies from package-lock.json. - Updated 'semver' version to 7.7.1 in multiple locations. - Changed the postinstall script name to '_postinstall' in package.json for better compatibility.
Prepare for SB9 (part 2)
25 tasks
Sidnioulz
reviewed
Apr 6, 2025
- Replaced `@storybook/addon-essentials` and `@storybook/addon-interactions` with `@storybook/addon-docs` in package.json and .storybook/main.ts. - Updated import statements in Introduction.mdx to use `@storybook/addon-docs/blocks`. - Renamed the postinstall script in package.json to `_postinstall` for compatibility. - Updated various dependencies in package-lock.json to their latest versions, including `@auto-it` packages and Babel-related packages.
…20.x - Created a new build workflow to automate the build process on push events. - Updated the release workflow to use Node.js 20.x instead of 18.x for consistency across workflows.
Sidnioulz
reviewed
May 27, 2025
JReinhold
approved these changes
May 28, 2025
Collaborator
JReinhold
left a comment
JReinhold
left a comment
There was a problem hiding this comment.
@ndelangen I changed a few tsup and TS configurations, as you can see from my comments. Let's discuss this when you can, going to merge for now.
| autodocs: "tag", | ||
| }, | ||
| }; | ||
| addons: ["@storybook/addon-docs", "./local-preset.cjs"], |
Collaborator
There was a problem hiding this comment.
Changed to .cjs to be correct
Comment on lines
+4
to
+20
| "skipLibCheck": true, | ||
| "target": "es2023", // Node 20 according to https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-20 | ||
| "allowJs": true, | ||
| "resolveJsonModule": true, | ||
| "moduleDetection": "force", | ||
| "moduleResolution": "bundler", | ||
| "module": "preserve", | ||
| "jsx": "react", | ||
| "lib": ["es2020", "dom"], | ||
| "module": "commonjs", | ||
| "isolatedModules": true, | ||
| "verbatimModuleSyntax": true, | ||
| "strict": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "noImplicitOverride": true, | ||
| "noImplicitAny": true, | ||
| "rootDir": "./src", | ||
| "skipLibCheck": true, | ||
| "target": "ES2020" | ||
| "lib": ["es2023", "dom", "dom.iterable"], | ||
| "baseUrl": ".", | ||
| "rootDir": "./src" |
Collaborator
There was a problem hiding this comment.
changed this to follow https://www.totaltypescript.com/tsconfig-cheat-sheet#base-options and set target to es2023 to match Node 20: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-20
Comment on lines
-6
to
-12
| // The current browsers supported by Storybook v7 | ||
| const BROWSER_TARGET: Options["target"] = [ | ||
| "chrome100", | ||
| "safari15", | ||
| "firefox91", | ||
| ]; | ||
| const NODE_TARGET: Options["target"] = ["node18"]; |
Collaborator
There was a problem hiding this comment.
I removed browser targets as the manager+preview builders are going to bundle this accordingly anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.